Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719342 Jaroslav Reznik <jreznik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #2 from Jaroslav Reznik <jreznik@xxxxxxxxxx> 2011-07-14 10:31:30 EDT --- Name: ok Summary: License: ok URL: I think anyone from this three is ok, still better than just kde.org Sources: ok (md5sum 021e4ad479bb88937084d4510d1e1218) BRs: ok Conflicts: ok Desktop file validation: ok Updated icon cache: ok Macros used consistently: ok Docs: ok Ldconfig: ok Devel contains .so: ok, library itself in -lib subpackage rpmlint okular.spec okular.spec:84: W: macro-in-comment %{buildroot} okular.spec:84: W: macro-in-comment %{_kde4_libdir} #unpackaged files - commented out but contains libgwenview, is it intended? otherwise please remove this line okular.spec: W: invalid-url Source0: ftp://ftp.kde.org/pub/kde/stable/4.6.90/src/okular-4.6.90.tar.bz2 <urlopen error ftp error: 550 Failed to change directory.> 0 packages and 1 specfiles checked; 0 errors, 3 warnings. APPROVED, just fix the rpmlint issue -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review