[Bug 708532] Review Request: perl-Term-Animation - ASCII sprite animation framework

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=708532

--- Comment #14 from Itamar Reis Peixoto <itamar@xxxxxxxxxxxxxxxx> 2011-07-12 13:58:17 EDT ---
[itamar@itamarssd perl-Term-Animation]$ rpmlint
/home/itamar/rpmbuild/RPMS/noarch/perl-Term-Animation-2.6-6.fc15.noarch.rpm
perl-Term-Animation-2.6-6.fc15.src.rpm 
perl-Term-Animation.src: W: strange-permission perl-Term-Animation.spec 0600L
2 packages and 0 specfiles checked; 0 errors, 1 warnings.

-> chmod 644 perl-Term-Animation.spec

[ok] The package must be named according to the Package Naming Guidelines .
[ok] The spec file name must match the base package %{name}, in the format 
[ok] The package must meet the Packaging Guidelines .
[ok] The spec file must be written in American English. (habbla ingles)
[ok] The spec file for the package MUST be legible.     ( I am able to read)
[ok] The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
[ok] All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines inclusion
of those as BuildRequires is optional
[ok] Packages must NOT bundle copies of system libraries.
[ok]A package must own all directories that it creates. If it does not create a
directory that it uses, then it should require a package which does create that
directory. 
[ok]A Fedora package must not list a file more than once in the spec file's 
[ok] Each package must consistently use macros. [16]
[ok] The package must contain code, or permissable content.

[SHOULD-FIX] The package must be licensed with a Fedora approved license and
meet the 

-> 
Licensing Guidelines .
-> current license : GPL+

http://cpansearch.perl.org/src/KBAUCOM/Term-Animation-2.6/README
This library is free software; you can redistribute it and/or modify
it under the same terms as Perl itself.

look - > https://fedoraproject.org/wiki/Packaging:Perl#License_tag
change to -> License:  GPL+ or Artistic


[SHOULD-FIX] - fix source url
-> https://fedoraproject.org/wiki/Packaging:Perl#URL_tag

change URL to -> URL: http://search.cpan.org/dist/perl-Term-Animation/

[SHOULD-FIX] - your %doc is empty.
I think you should add README and Changes file

change to -> %doc Changes README

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]