Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=710995 --- Comment #6 from Ankur Sinha <sanjay.ankur@xxxxxxxxx> 2011-07-12 12:03:35 EDT --- (In reply to comment #5) > Don't parse "ls". Using the find command is a lot cleaner. Something like: > > find . -type f \( -name "*.cpp" -o -name "*.h" -o -name "*.c" -o -name "*.xpm" > \) -exec chmod a-x {} \; > find gives me a "too many open files error" at times. > You're missing the .desktop file and icons though. I'd just chmod the whole src > directory. Done > > Don't install the documentation manually. Use the %doc macro instead (and put > it first under %files -- that is common). Please visit the RPM documentation on > how to use it. Done > > Ad iconv: Try iconv -f iso-8859-1 -t utf-8 dicomfformat_8c.xml Done > > (Probably put that desktop file comment above the three seds. You might want to > start your comments with either a capital letter or not, but not mix it, but > that is just a question of style and not necessary for the review.) Corrected. http://ankursinha.fedorapeople.org/kradview/kradview-1.1.0-4.fc15.src.rpm http://ankursinha.fedorapeople.org/kradview/kradview.spec Thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review