Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717966 --- Comment #7 from Chris Lalancette <clalance@xxxxxxxxxx> 2011-07-12 09:54:03 EDT --- Thanks for the review, Mark. (In reply to comment #3) > Okay, first up ... rpmlint output: > > python-psphere.spec: W: invalid-url Source0: > http://bitbucket.org/jkinred/psphere/get/python-psphere-0.1.tar.gz HTTP Error > 500: Internal Server Error > 0 packages and 1 specfiles checked; 0 errors, 1 warnings. > > python-psphere.noarch: W: spelling-error Summary(en_US) vSphere -> v Sphere, > sphere, spherule > python-psphere.noarch: W: summary-not-capitalized C vSphere SDK for Python > python-psphere.noarch: W: spelling-error %description -l en_US vSphere -> v > Sphere, sphere, spherule > python-psphere.noarch: W: no-documentation > python-psphere.noarch: E: non-executable-script > /usr/lib/python2.7/site-packages/psphere/scripting.py 0644L /usr/bin/env > 1 packages and 0 specfiles checked; 1 errors, 4 warnings. > > What I think needs fixing: > > - There is no 0.1 release of psphere yet, so we should either wait for a > release or (uggh) get into: > > > http://fedoraproject.org/wiki/Packaging:NamingGuidelines#NonNumericRelease This is the nastiest one here. When you run "python setup.py sdist" on the hg sources, you get a tarball out that is named "psphere-0.1.tar.gz". Given the "Referencing_Source" link below, I feel like we should stick with that version number, even though there is no official upstream release. > > - We need either a URL for the tarball created by upstream, or no > URL at all and instructions on how to regenerate the tarball from > a tag. See: > > http://fedoraproject.org/wiki/Packaging:SourceURL#Referencing_Source Right, fixed this up according to the link above. > > - The non-executable-script error can be fixed using a variant of: > > > http://fedoraproject.org/wiki/Packaging_tricks#Remove_shebang_from_Python_libraries Stolen from your example SPEC, and fixed. > > What can be ignored: > > - Spelling warnings about vSphere, it's correct > > - no-documentation warning - none is included in the tarball > > - The licensing change; no need to wait for that, GPLv3 is perfectly > fine for inclusion into Fedora (In reply to comment #4) > Okay, some more comments: > > - no need for the BuildRoot tag anymore > http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag Removed. > > - no need for %clean section anymore > http://fedoraproject.org/wiki/Packaging/Guidelines#.25clean Removed. > > - the description should be longer and end with a period. Can just take > the "Welcome" text from the website Fixed. > > - the -n argument to %setup is redundant; you're using the default value Fixed. > > - no need for Prefix tag Removed. > > - we should own the /usr/lib/python2.7/site-packages/psphere/ directory Fixed. > > - recommendation is to avoid using INSTALLED_FILES > http://fedoraproject.org/wiki/Packaging:Python#Byte_compiling > http://fedoraproject.org/wiki/Packaging:Python_Eggs Fixed. > > - use the %{__python} macro Fixed. > > - URL: instead of Url: Fixed. > > - should pass --skip-build argument to setuptools install Fixed. > > - I'd avoid the optimize argument to setuptools install, no reason to > override the default Fixed. I've uploaded a new SPEC: http://people.redhat.com/clalance/python-psphere/python-psphere.spec and new SRPM: http://people.redhat.com/clalance/python-psphere/python-psphere-0.1-4.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review