Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719854 --- Comment #12 from Steve Traylen <steve.traylen@xxxxxxx> 2011-07-12 08:31:11 EDT --- (In reply to comment #9) > 2) License > The license should be probably "GPLv2+ or Ruby or MIT" and according to readme, > there are also some files licensed under the same terms as Perl. > [1] http://www.yoshidam.net/Ruby.html#xmlparser Just to be clear I had not done the full review yet and had not checked the licensing. The licensing is impressively confused in fact. http://www.yoshidam.net/xmlparser_en.txt and the README gives part Ruby or "license of expat" and also bizarrely partly there is a Perl license on encoding.h In addition: xpath.rb is GPLv2+ so this all resolves to License: GPLv2+ and ( Ruby or GPLv2+ ) and ( GPLv2+ or Artistic ) which would definitely need some comments to explain which file is which. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review