Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719854 --- Comment #10 from Steve Traylen <steve.traylen@xxxxxxx> 2011-07-12 04:45:16 EDT --- > 4) BuildRoot is not required anymore > > 5) %clean section is not required > > 6) defattr is obsolete But you can leave them in if you are targeting older platforms as well, e.g RHEL6 as well. The other comments look to all be valid. Once you provide some informal review examples I will complete the formal review of the package. Steve. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review