Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: courier-authlib - Courier authentication library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208064 ------- Additional Comments From mfleming+rpm@xxxxxxxxxxxxxxxx 2007-01-06 20:21 EST ------- OK, I've had a closer look at this. There's not much left to fix up, don't let the length of the review fool you :-). Fix these and I can check and approve this without a hassle. The following is all OK: * RPM name is OK * Source courier-authlib-0.58.tar.bz2 is the same as upstream * Builds in mock (i386 / x86_64, FC5 and FC6) * Runs OK. NEEDSWORK: * Lose the courier_release / distribution detection routines, they're not needed for Fedora purposes and (IMO) just clutter the specfile. Disttags alone should do the desired job. * BuildRequires: gcc-c++ should not be included (wiki: PackagingGuidelines#Exceptions) * Requires: %{name} = %{version}-%{release} would be preferred to having an explicit "0" Epoch in the subpackage reqs. * Update to 0.59, which works quite well. RPMLINT: E: courier-authlib non-standard-executable-perm /etc/rc.d/init.d/courier-authlib 0555 * Hack this to 755/750 in %files to shut it up. E: courier-authlib postin-without-ldconfig /usr/lib/courier-authlib/libcourierauth.so.0.0.0 E: courier-authlib library-without-ldconfig-postun /usr/lib/courier-authlib/libcourierauth.so.0.0.0 * These are dlopen()ed IIRC, so this can actually be ignored. E: courier-authlib non-standard-executable-perm /usr/libexec/courier-authlib/authmigrate 0555 E: courier-authlib non-standard-executable-perm /usr/libexec/courier-authlib/sysconftool 0555 * Change this to 755 in the spec (It's there in lines 5 and 6 after %install) and this goes away too (what's Sam thinking here??) E: courier-authlib non-readable /var/spool/authdaemon/pid.lock 0600 E: courier-authlib non-readable /etc/authlib/authmysqlrc.dist 0660 E: courier-authlib non-readable /etc/authlib/authldaprc.dist 0660 E: courier-authlib non-readable /etc/authlib/authdaemonrc.dist 0660 E: courier-authlib non-readable /etc/authlib/authpgsqlrc.dist 0660 * Ignore these (running RPMlint as non-privileged user) W: courier-authlib non-conffile-in-etc /etc/authlib/authmysqlrc.dist W: courier-authlib non-conffile-in-etc /etc/authlib/authldaprc.dist W: courier-authlib non-conffile-in-etc /etc/authlib/authdaemonrc.dist W: courier-authlib non-conffile-in-etc /etc/authlib/authpgsqlrc.dist 55 * I'd ignore these too (rpmlint doesn't seem to recognise these for some reason) E: courier-authlib postin-without-ldconfig /usr/lib/courier-authlib/libcourierauthcommon.so.0.0.0 E: courier-authlib library-without-ldconfig-postun /usr/lib/courier-authlib/libcourierauthcommon.so.0.0.0 E: courier-authlib postin-without-ldconfig /usr/lib/courier-authlib/libauthcustom.so.0.0.0 E: courier-authlib library-without-ldconfig-postun /usr/lib/courier-authlib/libauthcustom.so.0.0.0 E: courier-authlib postin-without-ldconfig /usr/lib/courier-authlib/libcourierauthsasl.so.0.0.0 E: courier-authlib library-without-ldconfig-postun /usr/lib/courier-authlib/libcourierauthsasl.so.0.0.0 E: courier-authlib postin-without-ldconfig /usr/lib/courier-authlib/libcourierauthsaslclient.so.0.0.0 E: courier-authlib library-without-ldconfig-postun /usr/lib/courier-authlib/libcourierauthsaslclient.so.0.0.0 E: courier-authlib postin-without-ldconfig /usr/lib/courier-authlib/libauthpam.so.0.0.0 E: courier-authlib library-without-ldconfig-postun /usr/lib/courier-authlib/libauthpam.so.0.0.0 * dlopen()ed again I believe, don't worry too much. E: courier-authlib non-standard-dir-perm /var/spool/authdaemon 0750 * I actually have this as 755 on my server, as I'm often running maildrop / imapd as the delivering user (not daemon/bin/root/mail etc.). YMMV, but my solution keeps rpmlint happy and allows any calling user to access the world-writable socket it contains. W: courier-authlib service-default-enabled /etc/rc.d/init.d/courier-authlib E: courier-authlib no-status-entry /etc/rc.d/init.d/courier-authlib Patch the included init file for this one (Swap "2345" for "-" for the first issue and steal the stanza from rpmdevtools' template.init for the status. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review