Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719854 --- Comment #7 from Steve Traylen <steve.traylen@xxxxxxx> 2011-07-11 06:47:50 EDT --- Concerning the %{SOURCE} item the following is I think better and does work. %prep %setup -q -c -T cp -p %{SOURCE0} %{gemname}-%{version}.gem %build mkdir -p .%{gemdir} #gem install -V --local --install-dir $(pwd)/%{gemdir} --no-rdoc --no-ri --force %{gemname}-%{version}.gem gem install -V --local --install-dir $(pwd)/%{gemdir} --no-rdoc --no-ri --force %{gemname}-%{version}.gem I appreciate it makes no difference in reality but is consistant with the flow of other packages. I also see my earlier example rubygem-rake uses %{SOURCE0} in %build but I believe this to be wrong. Anyway other things: 1) Requires: expat is not needed, see: http://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires %global ruby_sitearch %(ruby -rrbconfig -e "puts Config::CONFIG['sitearchdir']") %global ruby_sitelib %(ruby -rrbconfig -e "puts Config::CONFIG['sitelibdir']") is defined conditionally, http://fedoraproject.org/wiki/Packaging:Ruby %{!?ruby_sitelib: %global rub.... The rational being that in some future fedora version these macros will be defined like e.g. the python ones. 3) Your changelog is not actually being updated between these increments. Genrally this package is looking better now, in order for me to sponsor you which I am willing to do can you maybe submit another package for review possibly but certainly provide an informal review of some other packages. Choose a package from : http://fedoraproject.org/PackageReviewStatus/NEW.html I would avoid the shaded "sponsor needed ones" when you have made a review of package there which you mark as informal review provide a link here to it. The other thing you can do now is submit this .src.rpm to koji as a --scratch build. For the sake of openness I declare also now that I work with and know you. Steve. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review