Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717502 --- Comment #15 from Volker Fröhlich <volker27@xxxxxx> 2011-07-10 18:38:46 EDT --- Please use the %doc macro instead of %{_docdir}/%{name}-%{version}/...! You could also include THANKS. I think the icon should go to %{_datadir}/pixmaps and the icon entry in the desktop file should reflect that. Ideally, it should be stated as mentioned here: http://fedoraproject.org/wiki/Packaging:Guidelines#Icon_tag_in_Desktop_Files Please change the permission of your spec file to 644. mkdir -p %{buildroot}/%{_datadir}/locale/es/LC_MESSAGES -- Why that? You could put in some comments. "... for developing micro-controllers firmware" -- Shouldn't that be "micro-controller"? Don't spell "Multiple" with a capital M in the description. Descriptions normally end with a period. You can drop the defattr line. Since some of your BRs are not available in EPEL, you can remove: - Build root definition - rm -rf %{buildroot} If you plan to get the missing dependencies into EPEL, please ignore that suggestion. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review