[Bug 713313] Review Request: msktutil - Program for interoperability with Active Directory

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=713313

--- Comment #3 from Volker Fröhlich <volker27@xxxxxx> 2011-07-10 17:54:29 EDT ---
Please put each BuildRequires on a separate line. This is much easier to look
over. If you decide not to do so, remove the comma.

Please include ChangeLog as documentation.

You can remove the defattr line, if you want.

I suggest to list the files explicitly in the files section, instead of using
globs. That reduces the risk of packaging files inadvertently. Keep a * instead
of .gz for the manpage though, as that could change.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]