Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712923 Christoph Wickert <cwickert@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #20 from Christoph Wickert <cwickert@xxxxxxxxxxxxxxxxx> 2011-07-09 11:11:24 EDT --- OK - MUST: $ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/gnome-contacts-* gnome-contacts.x86_64: E: incorrect-fsf-address /usr/share/doc/gnome-contacts-0.1.1/COPYING gnome-contacts.x86_64: W: no-manual-page-for-binary gnome-contacts gnome-contacts-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-contacts-0.1.1/src/contacts-app.c gnome-contacts-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-contacts-0.1.1/src/contacts-contact-pane.c gnome-contacts-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-contacts-0.1.1/src/contacts-list-pane.c gnome-contacts-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-contacts-0.1.1/src/contacts-types.c gnome-contacts-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-contacts-0.1.1/src/contacts-contact.c gnome-contacts-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-contacts-0.1.1/src/main.c gnome-contacts-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-contacts-0.1.1/src/contacts-utils.c gnome-contacts-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-contacts-0.1.1/src/contacts-store.c gnome-contacts-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-contacts-0.1.1/src/contacts-menu-button.c 3 packages and 0 specfiles checked; 10 errors, 1 warnings. OK - MUST: named according to the Package Naming Guidelines OK - MUST: spec file name matches the base package %{name} OK - MUST: package meets the Packaging Guidelines OK - MUST: Fedora approved license and meets the Licensing Guidelines (GPLv2+) OK - MUST: License field in spec file matches the actual license OK - MUST: license file included in %doc OK - MUST: spec is in American English OK - MUST: spec is legible OK - MUST: sources match the upstream source by MD5 06aeec251464cc5fb2a5731e830335b3 OK - MUST: successfully compiles and builds into binary rpms on i686 and x86_64 N/A - MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. OK - MUST: all build dependencies are listed in BuildRequires. OK - MUST: handles locales properly with %find_lang N/A - MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. OK - MUST: Package does not bundle copies of system libraries. N/A - MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. OK - MUST: owns all directories that it creates (only %{_datadir}/%{name}) OK - MUST: no duplicate files in the %files listing OK - MUST: Permissions on files are set properly but does not include %defattr(...) OK - MUST: consistently uses macros OK - MUST: package contains code, or permissable content N/A - MUST: Large documentation files should go in a -doc subpackage OK - MUST: Files included as %doc do not affect the runtime of the application N/A - MUST: Header files must be in a -devel package N/A - MUST: Static libraries must be in a -static package N/A - MUST: library files that end in .so are in the -devel package. N/A - MUST: devel packages must require the base package using a fully versioned dependency OK - MUST: The package does not contain any .la libtool archives. OK - MUST: The package contains a GUI application and includes a %{name}.desktop file, and that file is properly validated with desktop-file-validate in the %install section. OK - MUST: package does not own files or directories already owned by other packages. OK - Should: at the beginning of %install, the package runs $RPM_BUILD_ROOT. OK - MUST: all filenames valid UTF-8 SHOULD Items: OK - SHOULD: Source package includes license text(s) as a separate file. N/A - SHOULD: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available. OK - SHOULD: builds in mock. OK - SHOULD: compiles and builds into binary rpms on all supported architectures. OK - SHOULD: functions as described. N/A - SHOULD: Scriptlets are sane. N/A - SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. N/A - SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg N/A - SHOULD: no file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin N/A - SHOULD: package should contain man pages for binaries/scripts. Other items: OK - latest stable version OK - SourceURL valid OK - Compiler flags ok OK - Debuginfo complete N/A - SHOULD: package has a %clean section, which contains rm -rf $RPM_BUILD_ROOT N/A - SHOULD: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. Suggestions: - Description could be more detailed. - Please include '%defattr(-,root,root,-)' in the files section. It's no longer strictly required, but assures compatibility with more rpm versions. - Same goes for %clean - The category 'System' in the desktop file is definitely wrong. Use desktop-file-install to change it to "GNOME;GTK;Office;ContactManagement;" and make sure the change gets upstreamed. - Drop README file as long as it's empty None of this is a blocker, so you can fix these later and to your own judgment. Please make sure to not accidentally try to bring this to F15, it won't build because folks os too old. Package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review