Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713320 --- Comment #16 from Steven Dake <sdake@xxxxxxxxxx> 2011-07-05 11:55:39 EDT --- I'll validate the remaining SHOULDs by EOD today. [ ] SHOULD: The reviewer should test that the package builds in mock. - [ ] SHOULD: The package should compile and build into binary rpms on all supported architectures [ ] SHOULD: The reviewer should test that the package functions as described. A package should not segfault instead of running, for example. [ ] SHOULD: If scriptlets are used, those scriptlets must be sane. This is vague, and left up to the reviewers judgement to determine sanity. thanks for the re-review Kaleb of the new upstream release. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review