Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=715119 Elder Marco <eldermarco@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eldermarco@xxxxxxxxx --- Comment #3 from Elder Marco <eldermarco@xxxxxxxxx> 2011-07-02 20:17:32 EDT --- Hi, just a few comments, * The License field must be GPLv3+ (see the source file provided by upstream) * Currently, the correct version is 0.1. (See the source file provided by upstream) * Add each dependency on a single line: Requires: python Requires: gnome-python2-gnomekeyring Requires: fuse-encfs It's more readable. * %setup -q -n gnome-encfs This line could be: %setup -q -n %{name} * %{__install} -m 755 gnome-encfs %{buildroot}%{_datadir}/%{name}/gnome-encfs.py And This line could be: %{__install} -m 755 %{name} %{buildroot}%{_datadir}/%{name}/%{name}.py But, * You don't need the file gnome-encfs (Source1). Just install gnome-encfs (from tarball) in %{buildroot}%{_bindir} rpmlint: $ rpmlint /var/lib/mock/fedora-15-x86_64/result/gnome-encfs-23hg-1.20110621.fc15.* gnome-encfs.noarch: W: spelling-error %description -l en_US keyring -> keying, key ring, key-ring gnome-encfs.noarch: W: spelling-error %description -l en_US login -> loin, logic, lo gin gnome-encfs.noarch: W: spelling-error %description -l en_US autostart -> auto start, auto-start, autos tart gnome-encfs.noarch: W: no-manual-page-for-binary gnome-encfs gnome-encfs.src: W: spelling-error %description -l en_US keyring -> keying, key ring, key-ring gnome-encfs.src: W: spelling-error %description -l en_US login -> loin, logic, lo gin gnome-encfs.src: W: spelling-error %description -l en_US autostart -> auto start, auto-start, autos tart gnome-encfs.src: W: invalid-url Source0: gnome-encfs.tar.gz 2 packages and 0 specfiles checked; 0 errors, 8 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review