Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714231 --- Comment #2 from Kevin Fenzi <kevin@xxxxxxxxx> 2011-07-02 12:29:42 EDT --- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. See below - License See below - License field in spec matches See below - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: a436f07cd3be24ae99ff33b748c6c664 SemanticMediaWiki1.5.6.tgz a436f07cd3be24ae99ff33b748c6c664 ../SOURCES/SemanticMediaWiki1.5.6.tgz OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have sane scriptlets. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. Looks like the skins/SMW_tooltip.js file is under a different LICENSE. (It's MIT). Also, there's only one file that says GPLv2 or later. So, I would say the License here should be: "GPL+ and GPLv2+ and MIT" 2. rpmlint says: mediawiki116-semantic.noarch: W: spelling-error %description -l en_US spinoff -> spin off, spin-off, Spinoza mediawiki116-semantic.noarch: E: incorrect-fsf-address /usr/share/doc/mediawiki116-semantic-1.5.6/COPYING mediawiki116-semantic.src: W: spelling-error %description -l en_US spinoff -> spin off, spin-off, Spinoza You might mail them about updating COPYING, others can be ignored. So, I think once the License is cleared up we are good to go. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review