Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=718317 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.gieseking@xxxxxx --- Comment #1 from Martin Gieseking <martin.gieseking@xxxxxx> 2011-07-02 04:32:05 EDT --- Hi Mario, here are some initial comments: - The package doesn't build for x86_64 because of the missing compiler flag -fPIC. You can fix it this way: * add $(OPT) to all lines calling "gcc -shared" in the Makefiles * replace OPT='%{optflags}' with OPT='%{optflags} -fPIC' in your spec file - You also must ensure that the plugins get installed below %{_libdir}. Currently, they always go to /usr/lib (should be /usr/lib64 on x86_64). * add ASLIBDIR='%{_libdir}/%{name}' to the make statement in %build * add ASLIBDIR="$RPM_BUILD_ROOT/%{_libdir}/%{name}" in %install - There's an "index out of bounds" warning that can lead to a segfault. Thus, I suggest to fix this by dropping the "+1" in line 1832 of asforca4/asforca4.c. If upstream is still alive, please report it upstream. There are also some further warnings that require some further attention by the author. - I think the themes and guile files should be moved from %{_libdir}/%name to %{_datadir}/%name - add short comments above the PatchX line(s) - drop INSTALL from %doc - fix the version number in the %changelog entry There are a few further issues to be fixed. I'll have a look into them later. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review