[Bug 718270] Review Request: openr2 - MFC/R2 telephony signaling protocol over E1 lines

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=718270

--- Comment #4 from Jeffrey C. Ollie <jeff@xxxxxxxxxx> 2011-07-01 15:13:32 EDT ---
(In reply to comment #3)
> we are in the wrong part of the world, because we still use E1 lines.
> 
> I don't have hardware to test too, I am poor, after everything ok we will send
> a mail to mailling list's (moy, asterisk-br, etc...) and ask the people to try
> it.

I can understand.

> can you make rpmlint happy ?

> openr2.x86_64: W: spelling-error %description -l en_US spandsp -> spandex,
> Span, span
> openr2.x86_64: W: spelling-error %description -l en_US libteletone -> limestone

These are false positives, the original spelling is correct.

> openr2.x86_64: W: invalid-license LGPLv2, LGPLv2+, GPLv2+
> openr2-devel.x86_64: W: invalid-license LGPLv2, LGPLv2+, GPLv2+
> openr2-debuginfo.x86_64: W: invalid-license LGPLv2, LGPLv2+, GPLv2+

The files are an odd mixture of licenses, so I think that the license line is
correct, rpmlint's being too picky.

> openr2.x86_64: W: file-not-utf8
> /usr/share/doc/openr2-1.3.1/doc/intro-openr2-es.alaw

Another false positive, this is a binary sound file.

> openr2.x86_64: W: no-manual-page-for-binary r2dtmf_detect

It'd be nice to have a manual page, but I really don't know enough to even
attempt to write one.

> openr2-debuginfo.x86_64: E: incorrect-fsf-address
> /usr/src/debug/openr2-1.3.1/src/openr2/queue.h
> openr2-debuginfo.x86_64: E: incorrect-fsf-address
> /usr/src/debug/openr2-1.3.1/src/queue.c
> openr2-debuginfo.x86_64: E: incorrect-fsf-address
> /usr/src/debug/openr2-1.3.1/src/openr2/r2engine.h
> openr2-debuginfo.x86_64: E: incorrect-fsf-address
> /usr/src/debug/openr2-1.3.1/src/r2engine.c

I'm not sure it's worth patching these files to have the correct address.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]