Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=718165 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Flag| |fedora-review? --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> 2011-07-01 06:23:26 EDT --- Review: + koji build->http://koji.fedoraproject.org/koji/taskinfo?taskID=3173566 + rpmlint output is ibus-gucharmap.src: W: invalid-url Source0: ibus-gucharmap-0ec429009.tar.gz + Other than following suggestions, package looks ok. Suggestions 1) I think you can use word "Gucharmap" as "gucharmap" as its the command name actually in %description and summary. 2) defattr(-,root,root,-) is not needed now as per new guidelines and its also pointless since rpm 4.4 version. See https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions 3) Is the Versioned Requires on ibus really a hard requirement to be mentioned in spec? you should just write Requires: ibus 4) Steps to reproduce tarball is not working git archive --format tar --prefix ibus-gucharmap-${ibusgucharmapcommit} ${ibusgucharmapcommit} |gzip -c > ../ibus-gucharmap-${ibusgucharmapcommit}.tar.gz ==> fatal: Not a valid object name Though not relevant here but I see build.log is showing same warning many times. Looks something like casting issue. Also, it showed zh_CN.po warning message. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review