Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=701079 --- Comment #6 from Ankur Sinha <sanjay.ankur@xxxxxxxxx> 2011-06-30 22:33:23 EDT --- (In reply to comment #5) > (In reply to comment #4) > > > ? Package is a GUI app and has a .desktop file > > ^^^ > > > > It is a GUI, isn't it? I haven't seen a desktop file in the source. If you can, > > please create one and add it as an extra source. Do also send this upstream. > > (Only if it is a GUI of course.) > > The package has a GUI, but a *.desktop file is not needed for Windowmaker > dockapps, because users don't start them from a menu. Usually, dockapps will be > launched from a startup script. No one of the current dockapp packages in > Fedora has a desktop file. Look here what "Spot" said: > > https://bugzilla.redhat.com/show_bug.cgi?id=478744#c4 > > > 3. Please report the incorrect FSF address upstream. > > Impossible, unfortunately. The development is down for a long time. In such > cases, I don't have to do anything, because there is no chance to get it ever > fixed upstream: > > https://bugzilla.redhat.com/show_bug.cgi?id=690919#c5 > > > Updated package: > > Spec URL: http://mariobl.fedorapeople.org/Review/SPECS/wmSun.spec > SRPM URL: > http://mariobl.fedorapeople.org/Review/SRPMS/wmSun-1.03-3.fc15.src.rpm Hello! [ankur@ankur SRPMS]$ rpmlint ../SPECS/wmSun.spec wmSun-1.03-3.fc15.src.rpm /var/lib/mock/fedora-rawhide-i386/result/*.rpm ../SPECS/wmSun.spec:51: W: macro-in-%changelog %{buildroot} wmSun.src: W: spelling-error Summary(en_US) dockapp -> dock app, dock-app, paddock wmSun.src: W: spelling-error %description -l en_US dockapp -> dock app, dock-app, paddock wmSun.src:51: W: macro-in-%changelog %{buildroot} wmSun.i686: W: spelling-error Summary(en_US) dockapp -> dock app, dock-app, paddock wmSun.i686: W: spelling-error %description -l en_US dockapp -> dock app, dock-app, paddock wmSun.i686: E: incorrect-fsf-address /usr/share/doc/wmSun-1.03/COPYING wmSun.src: W: spelling-error Summary(en_US) dockapp -> dock app, dock-app, paddock wmSun.src: W: spelling-error %description -l en_US dockapp -> dock app, dock-app, paddock wmSun.src:51: W: macro-in-%changelog %{buildroot} wmSun-debuginfo.i686: E: debuginfo-without-sources 4 packages and 1 specfiles checked; 2 errors, 9 warnings. - You can maybe change the spelling (dockapp -> dock app). - You can also get rid of the rm -rf $RPM_BUILD_ROOT in the install section. It is not needed any more. - Debuginfo is still empty. This is because the fedora optflags are not being honoured in the build: DEBUG: + make 'CFLAGS=-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -Wl,-z,relro -m32 -march=i6 86 -mtune=atom -fasynchronous-unwind-tables' -j4 DEBUG: gcc -DLinux -c wmSun.c -o wmSun.o -I/usr/X11R6/include/X11 DEBUG: gcc -DLinux -c SunRise.c -o SunRise.o -I/usr/X11R6/include/X11 DEBUG: gcc -DLinux -c ../wmgeneral/wmgeneral.c -o ../wmgeneral/wmgeneral.o -I/usr/X11R6/include/X11 DEBUG: gcc -lm -o wmSun wmSun.o SunRise.o ../wmgeneral/wmgeneral.o -I/usr/X11R6/include/X11 -L/usr/X11R6/lib -lXpm -lX11 -lXext Even though CFLAGS has been defined in the makefile, they aren't used in the compile command. Change the make command as so: make COPTS='%{optflags}' %{?_smp_mflags} This fixes it. Thanks, Ankur -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review