Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=710995 --- Comment #2 from Ankur Sinha <sanjay.ankur@xxxxxxxxx> 2011-06-30 14:47:39 EDT --- (In reply to comment #1) > The invalid URL is easy to sort out: http://www.orcero.org/irbis/kradview Corrected. > > I suggest to run rpmlint on ALL your RPM files or run it after having installed > the packages: rpmlint my_package > > No buildroot definition, no rm -rf $RPM_BUILD_ROOT necessary. > > $ desktop-file-validate ./src/kradview.desktop > ./src/kradview.desktop: warning: key "Encoding" in group "Desktop Entry" is > deprecated Corrected. > ./src/kradview.desktop: warning: value "kradview %i %m -caption "%c"" for key > "Exec" in group "Desktop Entry" contains a deprecated field code "%m" Don't know how to correct this. Letting this warning be. > ./src/kradview.desktop: warning: boolean key "Terminal" in group "Desktop > Entry" has value "0", which is deprecated: boolean values should be "false" or > "true" > Corrected. > I'm not an expert in Docbook, but it seems to me, the documentation is still in > Docbook format -- not HTML. The build is supposed to generate the documentation. It requires doxygen. I'll look into it. > > It is common to put %doc as the first element of the files list, but don't know > whether it's a rule. [ankur@ankur SRPMS]$ rpmlint ../SPECS/kradview.spec kradview-1.1.0-2.fc15.src.rpm /var/lib/mock/fedora-rawhide-i386/result/*.rpm kradview.i686: W: no-manual-page-for-binary kradview_client kradview.i686: W: no-manual-page-for-binary kradview 4 packages and 1 specfiles checked; 0 errors, 2 warnings. Updated spec/srpm: http://ankursinha.fedorapeople.org/kradview/kradview.spec http://ankursinha.fedorapeople.org/kradview/kradview-1.1.0-2.fc15.src.rpm Thanks! Ankur -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review