Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=701079 Ankur Sinha <sanjay.ankur@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo? --- Comment #4 from Ankur Sinha <sanjay.ankur@xxxxxxxxx> 2011-06-30 13:29:07 EDT --- Review: + OK - NA ? Issue + Package meets naming and packaging guidelines + Spec file matches base package name. + Spec has consistant macro usage. + Meets Packaging Guidelines. + License + License field in spec matches + License file included in package + Spec in American English + Spec is legible. + Sources match upstream md5sum: [ankur@ankur rpmbuild]$ md5sum wmSun-1.03.tar.gz SOURCES/wmSun-1.03.tar.gz 34a2ea132f1a04e18be2d93abce40722 wmSun-1.03.tar.gz 34a2ea132f1a04e18be2d93abce40722 SOURCES/wmSun-1.03.tar.gz - Package needs ExcludeArch + BuildRequires correct - Spec handles locales/find_lang - Package is relocatable and has a reason to be. + Package has %defattr and permissions on files is good. + Package has a correct %clean section. + Package has correct buildroot %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) + Package is code or permissible content. - Doc subpackage needed/used. + Packages %doc files don't affect runtime. - Headers/static libs in -devel subpackage. - Spec has needed ldconfig in post and postun - .pc files in -devel subpackage/requires pkgconfig - .so files in -devel subpackage. - -devel package Requires: %{name} = %{version}-%{release} - .la files are removed. ? Package is a GUI app and has a .desktop file ^^^ It is a GUI, isn't it? I haven't seen a desktop file in the source. If you can, please create one and add it as an extra source. Do also send this upstream. (Only if it is a GUI of course.) + Package compiles and builds on at least one arch. + Package has no duplicate files in %files. + Package doesn't own any directories other packages own. + Package owns all the directories it creates. ? No rpmlint output. [ankur@ankur SRPMS]$ rpmlint ../SPECS/wmSun.spec wmSun-1.03-2.fc15.src.rpm /var/lib/mock/fedora-rawhide-i386/result/*.rpm ../SPECS/wmSun.spec:51: W: macro-in-%changelog %{buildroot} wmSun.src: W: spelling-error Summary(en_US) dockapp -> dock app, dock-app, paddock wmSun.src: W: spelling-error %description -l en_US dockapp -> dock app, dock-app, paddock wmSun.src:51: W: macro-in-%changelog %{buildroot} wmSun.i686: W: spelling-error Summary(en_US) dockapp -> dock app, dock-app, paddock wmSun.i686: W: spelling-error %description -l en_US dockapp -> dock app, dock-app, paddock wmSun.i686: E: incorrect-fsf-address /usr/share/doc/wmSun-1.03/COPYING wmSun.src: W: spelling-error Summary(en_US) dockapp -> dock app, dock-app, paddock wmSun.src: W: spelling-error %description -l en_US dockapp -> dock app, dock-app, paddock wmSun.src:51: W: macro-in-%changelog %{buildroot} wmSun-debuginfo.i686: E: empty-debuginfo-package 4 packages and 1 specfiles checked; 2 errors, 9 warnings. ^^^ -> I see you're using the -s (strip) option while installing. Please do not do that. http://fedoraproject.org/wiki/Packaging:Debuginfo#Useless_or_incomplete_debuginfo_packages_due_to_packaging_issues -> The macro in changelog is ignorable. + final provides and requires are sane: [ankur@ankur result]$ review-req-check == wmSun-1.03-2.fc16.i686.rpm == Provides: wmSun = 1.03-2.fc16 wmSun(x86-32) = 1.03-2.fc16 Requires: libX11.so.6 libXext.so.6 libXpm.so.4 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libm.so.6 libm.so.6(GLIBC_2.0) rtld(GNU_HASH) == wmSun-1.03-2.fc16.src.rpm == Provides: Requires: libXext-devel libXpm-devel == wmSun-debuginfo-1.03-2.fc16.i686.rpm == Provides: wmSun-debuginfo = 1.03-2.fc16 wmSun-debuginfo(x86-32) = 1.03-2.fc16 Requires: SHOULD Items: + Should build in mock. + Should build on all supported archs - Should function as described. + Should have sane scriptlets. - Should have subpackages require base package with fully versioned depend. + Should have dist tag + Should package latest version - check for outstanding bugs on package. (For core merge reviews) Issues: 1. buildroot tag isn't required any more 2. the clean section isn't required any more 3. Please report the incorrect FSF address upstream. 4. Please remove the -s flag from install. It should then generate debuginfo. Small, easily correctable issues :) Thanks, Ankur. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review