Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717645 Vít Ondruch <vondruch@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #1 from Vít Ondruch <vondruch@xxxxxxxxxx> 2011-06-30 11:26:45 EDT --- Hi Chris, by coincidence, I did the same package today before I noticed you did that yesterday :) So you can take a look for comparison [1]. A few things I noticed in you spec file: * Wrong license * site_libdir is useless for gem packages * you do not provide -doc subpackage, although I am not sure if we should not disable the documentation for this gem at all * %defattr is no more needed except EPEL-4 * BuildRoot is deprecated, except EPEL-5 and older I guess * Clean section is not required anymore * There is better to use %{geminstdir} macro in %files section [1] http://people.redhat.com/vondruch/rubygem-compass-960-plugin.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review