Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714336 --- Comment #4 from Ankur Sinha <sanjay.ankur@xxxxxxxxx> 2011-06-29 10:29:07 EDT --- (In reply to comment #3) > Again: Please don't upload files using the same release number as before. It > makes work harder for the reviewer. > Sorry, will do. > g++ -c predicates.cxx is still there. Added a dirty work around to make this work. Please note that it follows all the optflags other than -O2. The makefile says the file should be compiled with the -O0 flag to work properly (no optimization). > > What do you think of that other paragraph of the description? Does it help the > Fedora user? The package already built the binary, so it is pointless, from my > point of view. If I wanted to install this package, I wouldn't mind, if it > built on Windows too. And if I wanted to see what language it was written in, > I'd seek for the source code. > There's no harm in letting it be. It only gives the user some information. For example, it tells him that the application is also available for other OSes. I don't see a reason to remove it. :) > As of the documentation: If it is not very big, include it in the main package. Included. [ankur@ankur SPECS]$ rpmlint tetgen.spec ../SRPMS/tetgen-1.4.3-2.fc15.src.rpm ../RPMS/x86_64/tetgen-* tetgen.src: W: spelling-error %description -l en_US tetrahedralizations -> rationalizations, liberalizations tetgen.x86_64: W: spelling-error %description -l en_US tetrahedralizations -> rationalizations, liberalizations tetgen.x86_64: W: no-manual-page-for-binary tetgen 3 packages and 1 specfiles checked; 0 errors, 3 warnings. New spec/srpm: http://ankursinha.fedorapeople.org/tetgen/tetgen-1.4.3-2.fc15.src.rpm http://ankursinha.fedorapeople.org/tetgen/tetgen.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review