Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717345 Volker Fröhlich <volker27@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |volker27@xxxxxx --- Comment #2 from Volker Fröhlich <volker27@xxxxxx> 2011-06-28 17:34:52 EDT --- URL is supposed to be the website of the project. Please inform upstream, that the postal address of the FSF has changed and should be updated. ChangeLog, NEWS, TODO and INSTALL contain nothing useful. Better use %{_mandir}/man1/csync2.1.* instead of %{_mandir}/man1/csync2.1.gz. You can leave out defattr. The _sharedstatedir macro is substituted with /var/lib. Please use -p along with install to preserve the timestamps. Why do you run make clean? You can also leave out the build target "all", as it is the first target, thus default. mkdir -p $RPM_BUILD_ROOT%{_var}/lib/csync2 also seems to be dispensable. I think, BuildRequires one per line is more legible. BR xinetd doesn't seem to be necessary. I guess you're aiming for EPEL. There is no sqlite2 package there. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review