Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=641957 Vít Ondruch <vondruch@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo?(vondruch@redhat.c | |om) | --- Comment #10 from Vít Ondruch <vondruch@xxxxxxxxxx> 2011-06-28 01:50:37 EDT --- Hello Chris, thank you for taking over this review. Since this package needs to be patched, it is necessary to install the gem in %prep section. Furthemore, the gem should be always installed in %prep section although the guidelines say something different atm. The reasons are: 1) The patch may be required in any time during the life of the gem and moving gem installation from %install into the %prep section is therefore required. If you install in %prep right from the start, you don't need to do this. 2) It is common for all packages to be installed in %prep section. It is bit clumsy with gems, but still its the best place IMO. I hope I find time to prepare updated guidelines one day. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review