[Bug 716402] Review Request: ckermit - The quintessential all-purpose communications program

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=716402

--- Comment #2 from Jon Ciesla <limb@xxxxxxxxxxxx> 2011-06-27 14:04:31 EDT ---
ckermit.src: W: file-size-mismatch x.tar.gz = 2413399,
http://www.columbia.edu/kermit/ftp/test/tar/x.tar.gz = 2413309
The size of the file in the package does not match the size indicated by
peeking at its URL.  Verify that the file in the package has the intended
contents.


Good:

- rpmlint checks return:

ckermit.src: W: file-size-mismatch x.tar.gz = 2413399,
http://www.columbia.edu/kermit/ftp/test/tar/x.tar.gz = 2413309
The size of the file in the package does not match the size indicated by
peeking at its URL.  Verify that the file in the package has the intended
contents.

Explained by comments.

- package meets naming guidelines
- package meets packaging guidelines
- license ( ) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream: No, but see above.
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 

Running mock build to rest BRs, but otherwise it looks great.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]