Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=641957 Chris Lalancette <clalance@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clalance@xxxxxxxxxx Flag| |needinfo?(vondruch@redhat.c | |om) --- Comment #9 from Chris Lalancette <clalance@xxxxxxxxxx> 2011-06-27 10:40:43 EDT --- Since this has been stale for so long, I'll take over the review here. [clalance@localhost ~]$ rpmlint rubygem-database_cleaner.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. [clalance@localhost ~]$ rpmlint rubygem-database_cleaner-0.6.6-1.fc15.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Based on the guidelines at: https://fedoraproject.org/wiki/Packaging:Ruby MUST require ruby abi: OK MUST be called rubygem-UPSTREAM: OK MUST have full URL to released gem archive: OK MUST Require rubygems: OK MUST BuildRequire rubygems: OK MUST Provide rubygem(%{gemname}): OK SHOULD have empty %prep: FAIL SHOULD have empty %build: OK MUST be installed into %{gemdir}: OK SHOULD be installed with gem install --local: FAIL MUST own gems, cache, and specifications: OK MUST not install arch-specific content into %{gemdir}: N/A MUST be marked as BuildArch noarch for pure ruby: OK This looks pretty good, except for the fact that the installation is done during the %prep section instead of during the %install section. However, I have seen reasons that this was necessary in the past, so if there is a good reason we can waive it. Vit, what is the reason that the "gem install" command is done in %prep as opposed to %install? Thanks, Chris Lalancette -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review