Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714543 Volker Fröhlich <volker27@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |volker27@xxxxxx --- Comment #5 from Volker Fröhlich <volker27@xxxxxx> 2011-06-26 19:03:53 EDT --- License is GPLv3+ -- not GPLv3, according to the files. You can replace the "maze5" in Source0 with the name macro. The Requires doesn't make sense: The main-package doesn't require itself. You can drop "rm -rf $RPM_BUILD_ROOT". It's not needed. The files section should be aggregated just before the changelog. %doc is usually in the first line. The GIMP plug-in directory is called "plug-ins", not "plugins", as far as I can see. The suffix "gimp", the plug-in has, seems somewhat strange to me. This sub-package should also require GIMP, I guess. Your sub-packages requires the main package, I suppose: http://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package Put the BR for gimp-devel-tools next to the other BRs. It doesn't make sense to split that. I think putting each BR on a separate line is more legible. "%{_mandir}/man1/maze5.1.gz" -- Rather make that "%{_mandir}/man1/maze5.1.*" Use -p with "install" to preserve timestamps. You're not using the proper compiler flags: http://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags Besides that: [makerpm@fedora15 SRPMS]$ rpmlint ../RPMS/x86_64/maze5-* maze5.x86_64: W: manual-page-warning /usr/share/man/man1/maze5.1.gz 80: a space character is not allowed in an escape name maze5.x86_64: W: manual-page-warning /usr/share/man/man1/maze5.1.gz 83: a space character is not allowed in an escape name maze5.x86_64: W: manual-page-warning /usr/share/man/man1/maze5.1.gz 83: a space character is not allowed in an escape name maze5.x86_64: W: manual-page-warning /usr/share/man/man1/maze5.1.gz 83: a space character is not allowed in an escape name maze5-gimp.x86_64: W: unstripped-binary-or-object /usr/lib64/gimp/2.0/plugins/maze5gimp -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review