Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608574 --- Comment #9 from Tim Lauridsen <tla@xxxxxxxxx> 2011-06-24 13:05:40 EDT --- Issues: [!] : MUST - Rpmlint output is silent. rpmlint tinymce-3.3.7-2.fc16.noarch.rpm ================================================================================ tinymce.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/tinymce-3.3.7/changelog.txt tinymce.noarch: W: file-not-utf8 /usr/share/doc/tinymce-3.3.7/changelog.txt tinymce.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/tinymce-3.3.7/license.txt 1 packages and 0 specfiles checked; 0 errors, 3 warnings. ================================================================================ You need to run dos2unix on the changelog.txt & license.txt convert changelog.txt to utf8 http://fedoraproject.org/wiki/Common_Rpmlint_issues#file-not-utf8 [!] : SHOULD - Latest version is packaged. Any reason for not packaging the latest version (3.4.x) ? [!] : SHOULD - Spec use %global instead of %define. %define ver %(echo %{version} | tr . _) Please use %global, instead of %define. [!] : MUST - Requires correct, justified where necessary. There are some comments about the Require: httpd I dont see any hard requirement for httpd, it could be runned locally So please justify the need for httpd -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review