Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713159 --- Comment #4 from Vít Ondruch <vondruch@xxxxxxxxxx> 2011-06-22 06:31:58 EDT --- * Please remove ruby_sitelib definition - This macro is useful only for gems with binary extension, which is not this case * License - According to LICENSE file, the license should be MIT * Requires versions: - Please remove the >= 0 versions, which is default * Each Ruby package must indicate the Ruby ABI version it depends on - Please add Requires and BuildRequires: ruby(abi) = 1.8 - I prefer also to depend explicitly on ruby, since JRuby are probably comming into Fedora soon * Please install gem with --bindir flag - --bindir .%{_bindir} should be used instead of some magic lines which moves the executables around. * Please execute the test suite. - This needs: BuildRequires: rubygem(nokogiri) >= 1.4.1 BuildRequires: rubygem(builder) - and the %check section: %check pushd %{buildroot}%{geminstdir} testrb -I lib test/test_*.rb popd * What is the puprose of vmodl.db file? - Is it necessary for runtime? - Is it database? - Is it readonly or should it be modifiable? - It seems to be referenced inrbvmomi/devel/analyze-vim-declarations.rb so it looks like some debug output to me. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review