[Bug 714899] Review Request: tbo - Gnome comic creator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=714899

--- Comment #5 from Veeti Paananen <veeti.paananen@xxxxxxxxxx> 2011-06-21 14:04:46 EDT ---
More comments:

1. Remove the --vendor option from desktop-file-install: according to the
guidelines, it shouldn't be used: "For new packages, do not apply a vendor tag
to desktop files."

2. You might want to fix the description text: "comic" should be "comics".

3. You should start updating the %changelog section every time you make changes
and post the new spec & SRPM here so that reviewers and commenters can keep
track of the changes you've made. (You also need to bump the Release number
every time you do so.)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]