Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714899 Veeti Paananen <veeti.paananen@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veeti.paananen@xxxxxxxxxx --- Comment #1 from Veeti Paananen <veeti.paananen@xxxxxxxxxx> 2011-06-21 08:42:11 EDT --- Just some comments: 1. Your build requirements are incomplete (missing at least GTK+). Use mock (http://fedoraproject.org/wiki/Using_Mock_to_test_package_builds) to test builds in a sandbox where all the build dependencies must be listed correctly. 2. I think that you need to use the %find_lang macro (http://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files) for the locale file. This will also futureproof the spec in case new translations are added to future versions. 3. Desktop files need to be installed using desktop-file-install or desktop-file-validate (http://fedoraproject.org/wiki/Packaging/Guidelines#desktop). 4. If you need a sponsor, you need to add "FE-NEEDSPONSOR" to the blocked bugs for this review request. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review