Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226117 --- Comment #34 from Jan Kaluža <jkaluza@xxxxxxxxxx> 2011-06-20 02:34:57 EDT --- Thank you for adding me into CC, I didn't know about this merge review (Maybe I should start searching for my packages names from time to time). If I understand this review well, it is about changing the directory structure and whole packaging process to fit better Fedora guidelines, right? As I've checked it so far, there's for example problem with "/usr/lib/mailman/Mailman/mm_cfg.py". Config files really should not be in /usr/lib. This is not easily fixable unless you start doing some magic like importing python files from /etc/mailman/. (Bug 683763) There is also problem with /etc/mailman/mm_cfg.py symlink, because if you run "rpmbuild" locally, it will generate "/etc/mailman/mm_cfg.pyo" and "/etc/mailman/mm_cfg.pyc". Current Mailman package workarounds it using "%{configdir}/mm_cfg.*" in %files section, but those files should not be there. Interesting thing is that those files are not generated when building using Koji. The solution for it is to byte-compile everything manually instead of /etc/mailman/ directory or to finish this RFE http://rpm.org/ticket/837 . > Considering the pace here it might be more efficient and realistic to work with > upstream to ensure that 3.0 will be more suitable for packaging according to > our guidelines. I think this is better idea probably. Mailman 3 fixes lot of things and I think they won't release alpha versions forever and if I consider this review request is here for 4.5 years... However, I will check the changes in .spec mentioned in this bug more closely to see what exactly changed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review