Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-twisted-news - Twisted News is an NNTP server and programming library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221309 kevin@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From kevin@xxxxxxxxx 2007-01-04 00:04 EST ------- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (MIT) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 62a93645867bacad4a4ca4d45e9ce090 TwistedNews-0.2.0.tar.bz2 62a93645867bacad4a4ca4d45e9ce090 TwistedNews-0.2.0.tar.bz2.1 b20aefb6002b6810361163b90f6d7a59ec9383ff TwistedNews-0.2.0.tar.bz2 b20aefb6002b6810361163b90f6d7a59ec9383ff TwistedNews-0.2.0.tar.bz2.1 OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. See below - No rpmlint output. OK - final provides and requires are sane: SHOULD Items: OK - Should build in mock. OK(i386/x86_64) - Should build on all supported archs OK - Should have dist tag OK - Should package latest version Issues: 1. rpmlint says: E: python-twisted-news no-binary Can be ignored in this case. I don't see any blockers here, so this package is APPROVED. Don't forget to close this request NEXTRELEASE once it's been imported and built. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review