Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698362 Elad Alfassa <el.il@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #8 from Elad Alfassa <el.il@xxxxxxxxxx> 2011-06-19 02:29:51 EDT --- + Package meets naming and packaging guidelines + Spec file matches base package name. + Spec has consistant macro usage. + Meets Packaging Guidelines. + License + License field in spec matches + License file included in package + Spec in American English + Spec is legible. - Package needs ExcludeArch + BuildRequires correct - Spec handles locales/find_lang - Package is relocatable and has a reason to be. + Package has %defattr and permissions on files is good. - Package has a correct %clean section. + Package has correct buildroot %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) + Package is code or permissible content. - Doc subpackage needed/used. + Packages %doc files don't affect runtime. - Headers/static libs in -devel subpackage. - Spec has needed ldconfig in post and postun - .pc files in -devel subpackage/requires pkgconfig - .so files in -devel subpackage. - -devel package Requires: %{name} = %{version}-%{release} - .la files are removed. + Package is a GUI app and has a .desktop file + Package compiles and builds on at least one arch. + Package has no duplicate files in %files. - Package doesn't own any directories other packages own. - Package owns all the directories it creates. ? No rpmlint output. writetype.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/writetype/espeakInterface.py 0644L /usr/bin/python writetype.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/writetype/listWidget.py 0644L /usr/bin/python writetype.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/writetype/ttsInterface.py 0644L /usr/bin/python writetype.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/writetype/festivalInterface.py 0644L /usr/bin/python writetype.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/writetype/pyttsxInterface.py 0644L /usr/bin/python writetype.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/writetype/main.py 0644L /usr/bin/python writetype.noarch: W: no-manual-page-for-binary writetype 2 packages and 0 specfiles checked; 6 errors, 1 warnings. The non-executable-script error is because of the (un-needed) shabang in the library files. I don't think it's a major issue, you can make a patch to remove the shabang from these files if you want. the no-manual-page error can be ignored. + final provides and requires are sane: writetype-1.2.130-5.fc16.noarch.rpm mimehandler(application/x-writetype) writetype = 1.2.130-5.fc16 = /bin/bash PyQt4 enchant festival python(abi) = 2.7 pyttsx rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PartialHardlinkSets) <= 4.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1 writetype-1.2.130-5.fc16.src.rpm = python2-devel python-setuptools desktop-file-utils rpmlib(FileDigests) <= 4.6.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 SHOULD Items: + Should build in mock. - Should build on all supported archs - Should function as described. - Should have sane scriptlets. - Should have subpackages require base package with fully versioned depend. + Should have dist tag + Should package latest version Seems fine, APPROVED. -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review