[Bug 712203] Review Request: eclipse-mercurial - Mercurial plugin for Eclipse

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=712203

--- Comment #12 from Andrew Overholt <overholt@xxxxxxxxxx> 2011-06-16 15:18:28 EDT ---
Sorry, Minoo, I shouldn't have suggested you ship a copy of the EPL in your
feature.  Referencing the LICENSE as it's included in the plugin is the correct
thing to do.  You can get rid of this line:  %doc
com.vectrace.mercurialeclipse-feature/epl-v10.html and drop that file from your
feature.  It also might be a good idea to add a version to the tarball of your
feature.  Something like com.vectrace.mercurialeclipse-feature-0.0.1.tar.bz2
might be good (make the version equal what's in your feature.xml).

Otherwise, we're good to go.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]