Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713690 VÃt Ondruch <vondruch@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |vondruch@xxxxxxxxxx Flag| |fedora-review+ --- Comment #4 from VÃt Ondruch <vondruch@xxxxxxxxxx> 2011-06-16 06:29:31 EDT --- I am taking this for review. According the guidelines for package renaming [1], your provides and obsoletes have to contain correct versions: Provides: rubygem(%{gemname}) = %{version} Provides: rubygem-right_http_connection = %{version} Obsoletes: rubygem-right_http_connection < 1.4.1-1 Also comment that this provides should be removed according to the guidelines would have sense. And don't forget to retire the old package. Otherwise, the package looks good => APPROVED [1] http://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.2FReplacing_Existing_Packages -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review