Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=689961 Elad Alfassa <el.il@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |el.il@xxxxxxxxxx --- Comment #2 from Elad Alfassa <el.il@xxxxxxxxxx> 2011-06-16 05:13:32 EDT --- (In reply to comment #1) > I don't see any blocking issues here, so were I a package maintainer, I would > declare this package APPROVED. Well, you are wrong. the package MUST contain a license file (unless it's public domain). It also must have a build section. Also, The user creation in %pre is not according to the guidelines, see https://fedoraproject.org/wiki/Packaging:UsersAndGroups Furthermore, it seems you get the sources directly from that git repository. why? Upstream doesn't release tarballs? if so, the version tag should be according to these guidelines: https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review