Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707002 --- Comment #3 from Ankur Sinha <sanjay.ankur@xxxxxxxxx> 2011-06-15 06:34:27 EDT --- (In reply to comment #2) > Hi Ankur, Hi Eric! > > Thanks for this great work. We are greatly pleased to be included in Fedora > Medical and in Fedora in general. Thank you for taking time out to give us these hints :D > > Just some comments on the presentation: > - license is mainly GPLv3 + LGPL (for some parts) Corrected. > - need Qt v4.6.2 at least Yes. I'm building against 4.7.2: [root@ankur ~]# repoquery qt-devel qt-devel-1:4.7.2-8.fc15.i686 > > For the spec: > - in order to create the translation add in the %build tag (before the qmake > step) > lrelease global_resources/translations/*.ts > - LOWERED_APPNAME=FreeMedForms --> needs to be lowered ;) so > LOWERED_APPNAME="freemedforms". Then libs and plugs should be installed in > %{_libdir}/freemedforms Corrected. > > I saw a problem with rpath, 0.5.9~alpha2 should solve it (idem for the debian > packages). I'll update the package once you release alpha2 :) > > There should be a small issue with the version numbering (because the version > is parsed in the code). Can't you use 0.5.9~alpha1 instead of 0.5.9-0.1.alpha1 > ? Otherwise I need to patch the 0.5.9~alpha2 code ;) Uhm, I'll have to ask around. From the guidelines, it should be "0.1.alpha2". Are you sure the versioning of the rpm has an affect on the package? I haven't changed the versioning in the build anywhere. It's only for the rpm. > > Can you add a link to our main website: http://www.freemedforms.com/ > Added :) > Fell free to contact us at any time for any question at > freemedforms@xxxxxxxxxxxxxxxx I just joined the google groups :) > > Thanks for your work > Eric Maeker I noticed that freemedforms also bundles quazip. However, the version bundled has a "global.h" file, which the latest quazip does not have: http://sourceforge.net/projects/quazip/files%2Fquazip%2F0.4.1%2Fquazip-0.4.1.tar.gz/download What version of quazip is being used here? Is this include from quazip, or a modification required only for freemedforms? In the meantime, I cannot build freemedforms :/ (due to the missing global.h file in the fedora quazip libraries) [root@ankur ~]# repoquery -l quazip-devel quazip | egrep "\.h$" /usr/include/quazip/JlCompress.h /usr/include/quazip/quaadler32.h /usr/include/quazip/quachecksum32.h /usr/include/quazip/quacrc32.h /usr/include/quazip/quazip.h /usr/include/quazip/quazipfile.h /usr/include/quazip/quazipfileinfo.h /usr/include/quazip/quazipnewinfo.h /usr/include/quazip/JlCompress.h /usr/include/quazip/quaadler32.h /usr/include/quazip/quachecksum32.h /usr/include/quazip/quacrc32.h /usr/include/quazip/quazip.h /usr/include/quazip/quazipfile.h /usr/include/quazip/quazipfileinfo.h /usr/include/quazip/quazipnewinfo.h Thank you Eric :) Ankur -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review