Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711762 HaÃkel GuÃmar <karlthered@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #9 from HaÃkel GuÃmar <karlthered@xxxxxxxxx> 2011-06-14 10:48:42 EDT --- package builds fine in mock (f15/devel on all primary arch) rpmlint output is ok: $ rpmlint -iv /var/lib/mock/fedora-15-x86_64/result/osc-0.132.1-2.fc15.src.rpm osc.src: I: checking osc.src: W: spelling-error Summary(en_US) openSUSE -> opens Use, open SUSE, open-SUSE The value of this tag appears to be misspelled. Please double-check. osc.src: W: spelling-error %description -l en_US Commandline -> Command line, Command-line, Commanding The value of this tag appears to be misspelled. Please double-check. osc.src: W: spelling-error %description -l en_US openSUSE -> opens Use, open SUSE, open-SUSE The value of this tag appears to be misspelled. Please double-check. osc.src: I: checking-url http://www.gitorious.org/opensuse/osc (timeout 10 seconds) osc.src:50: E: hardcoded-library-path in %{_prefix}/lib/osc A library path is hardcoded to one of the following paths: /lib, /usr/lib. It should be replaced by something like /%{_lib} or %{_libdir}. osc.src:51: E: hardcoded-library-path in %{_prefix}/lib/osc/complete A library path is hardcoded to one of the following paths: /lib, /usr/lib. It should be replaced by something like /%{_lib} or %{_libdir}. osc.src:62: E: hardcoded-library-path in %{_prefix}/lib/osc/complete A library path is hardcoded to one of the following paths: /lib, /usr/lib. It should be replaced by something like /%{_lib} or %{_libdir}. osc.src: W: invalid-url Source0: osc-0.132.1.tar.gz The value should be a valid, public HTTP, HTTPS, or FTP URL. 1 packages and 0 specfiles checked; 3 errors, 4 warnings. $ rpmlint -iv /var/lib/mock/fedora-15-x86_64/result/osc-0.132.1-2.fc15.noarch.rpm osc.noarch: I: checking osc.noarch: W: spelling-error Summary(en_US) openSUSE -> opens Use, open SUSE, open-SUSE The value of this tag appears to be misspelled. Please double-check. osc.noarch: W: spelling-error %description -l en_US Commandline -> Command line, Command-line, Commanding The value of this tag appears to be misspelled. Please double-check. osc.noarch: W: spelling-error %description -l en_US openSUSE -> opens Use, open SUSE, open-SUSE The value of this tag appears to be misspelled. Please double-check. osc.noarch: I: checking-url http://www.gitorious.org/opensuse/osc (timeout 10 seconds) osc.noarch: W: no-manual-page-for-binary osc-wrapper.py Each executable in standard binary directories should have a man page. osc.noarch: W: no-manual-page-for-binary osc_hotshot.py Each executable in standard binary directories should have a man page. 1 packages and 0 specfiles checked; 0 errors, 5 warnings. About helper scripts, fedora preferred location is /usr/libexec though it's not in FHS (current proposal: http://bugs.freestandards.org/show_bug.cgi?id=718) and upstream won't fix it until then. The moment being, /usr/{lib,share} are **tolerated** locations (rpm, systemd, dracut, PackageKit, some system-config-* tools are in the same case). I'll remind you to be attentive on that topic. Except that particular issue, everything else is fine. I give you my blessing to import this package into fedora packages collection. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review