Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=710903 --- Comment #3 from Thomas Sailer <t.sailer@xxxxxxxxxxxxxx> 2011-06-14 09:30:00 EDT --- (In reply to comment #2) Thanks a lot for this review as well! I've changed the spec file according to your comments: http://sailer.fedorapeople.org/octave-miscellaneous.spec http://sailer.fedorapeople.org/octave-miscellaneous-1.0.11-2.fc15.src.rpm > 1) It would be nice to have a larger (less cryptic) description. I've enlarged the description, hopefully it makes more sense now. > 2) BuildRoot is no longer required in the spec files. Removed the build root. > 3) It is considered good style to have one BuildRequires for each package. The > advantage of this approach is that if one of them changes it is easier to read > using diff (or patch or...). I use now one BR line for each requirement. New Package SCM Request ======================= Package Name: octave-miscellaneous Short Description: Miscellaneous tools for octave that don't fit somewhere else Owners: sailer Branches: f15 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review