Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690728 --- Comment #37 from Jens Petersen <petersen@xxxxxxxxxx> 2011-06-13 23:43:57 EDT --- Thanks for the update. The rpmlint now looks clean - very good. Any suggestions how to test the package? (In reply to comment #35) > I changed Django from 1.2.3 to 1.2.5 Ok, but the question was: (why) do you need to specify the version there? Current Fedora has version 1.3. ;) I suggest not to specify the version or if you want to safeguard with a minimum safe django version use >=. The easiest is just to drop the version unless it is absolutely needed. > and fixed the issues you mentioned in comment 31 So you need mod_python? > http://yuwang.fedorapeople.org/nitrate.spec > https://fedorahosted.org/releases/n/i/nitrate/nitrate-3.3.4-2.src.rpm > https://fedorahosted.org/releases/n/i/nitrate/nitrate-3.3.4.tar.bz2 You changed the tarball without bumping the version which is generally considered bad practice. (You don't have to keep the upstream .spec file in sync for this review BTW, though you are free to backport changes when you want.) https://fedoraproject.org/wiki/PackagingDrafts/JavaScript As I said before I would like to see a declaration of all the third-party (javascript) libraries being used by nitrate, where they come from, and their license. Did you look at the tinymce review? (bug 608574) This library is large and certainly should be packaged separately. Since the above referenced package review seems to have stalled perhaps you could help to get the package into Fedora. (In reply to comment #36) > ./tcms/core/lib/odfpy => provided by package: odfpy.noarch > ./tcms/core/lib/django-pagination => provided by package: > django-pagination.noarch Thanks Athmane for catching this. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review