Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=710751 FranÃois Kooman <fkooman@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs? --- Comment #6 from FranÃois Kooman <fkooman@xxxxxxxxx> 2011-06-13 13:47:44 EDT --- Thanks for the review! Issues: - I removed the macro - upstream in trunk has "fixed" this, by setting 1.1.1-dev now, I hope they remove the "-dev" when it is time to release (http://svn.php.net/viewvc/pecl/oauth/trunk/php_oauth.h?revision=311716&view=markup, line 72) for now I can patch this myself. or should I just leave it? - The trunk version has some tests included, when/if 1.1.1 is released I'll add those tests to the spec file as well... You want to be co-maintainer for this package? New Package SCM Request ======================= Package Name: php-pecl-oauth Short Description: PHP OAuth extension Owners: fkooman Branches: f14 f15 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review