Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712522 --- Comment #3 from Alexander Kurtakov <akurtako@xxxxxxxxxx> 2011-06-12 06:13:01 EDT --- Not an official review as there are some critical pieces missing yet - nothing is installed :) relly. In your builddir/build/rpmbuild there are zips created for everyone of your rpmbuild calls you should unzip all of them in dropins. Other comments: * Drop rm -rf $RPM_BUILD_ROOT from install section * Drop the whole clean section * Drop %defattr(-,root,root,-) from files sections Some suggestions: * Fix the fetch script to not put things into directory common but %{name}-%{version} - it's way easier for maintenance and you can drop -c parameter from the setup macro call * You can try building the *.sdk features - it's not mandatory (i.e. I won't block the review on this) but it's really helpful to have them installed especially for packages containing common functionalities because usually these features contain the source bundles and documentation. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review