Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gocr - GNU Optical Character Recognition program https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216534 pertusus@xxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |pertusus@xxxxxxx OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From pertusus@xxxxxxx 2007-01-03 09:34 EST ------- * rpmlint says: E: gocr explicit-lib-dependency libjpeg I posted a comment above asking for that Requires, I guess there is an executable from libjpeg used for conversion. * follow guidelines X License is GPL, not included. You should ask upstream to include the license file, otherwise he may not be able to defend his license. Some file with an author and no license. This should be investigated and certainly corrected upstream. Except from otsu it is the upstream author, so ther shouldn't be much trouble. Maybe the upstream author thinks that no license means public domain, but it is not the case, he should either remove the author notice or explicitly license it in the public domain. otsu.c has no license but an author (in fact 2, as shown by looking at the comments). the following code was send by Ryan Dibble <dibbler@xxxxxxxxx> pnm.c has no license but an author /* (c) Joerg Schulenburg 2000-2006 pcx.c and tga.c have no license but an author // Joerg Schulenburg Mai99 // Joerg Schulenburg Mai99 * build and run fine * right Requires and BuildRequires. Maybe a comment explaining the need for the requires could be in order. * %files section right * sane provides * match upstream f989fe8e24f82d19c8ce55df15784e15 gocr-0.43.tar.gz The only remaining blocker is the license issue. A statement from upstream and a promise to fix things for the next release would be enough for me. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review