Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libundo - Undo/redo information managing library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221184 ------- Additional Comments From rc040203@xxxxxxxxxx 2007-01-03 03:59 EST ------- Some remarks: This package is causing me some gripes. 1. undo.h is being installed into /usr/include. 2. undo.h isn't C++-safe (it lacks the extern "C" guards 3. IMO, calling a library "undo", letting it contain symbols being prefixed "undo_*" and letting its headers provide defines such as "UNDO" isn't necessarily a clever design. None of these issues are blockers for inclusion into FE, but at least #1 and #2 are sufficient reason for me not to want "to dive into a formal review", sorry. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review