Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690728 --- Comment #34 from Jens Petersen <petersen@xxxxxxxxxx> 2011-06-09 02:03:15 EDT --- (In reply to comment #32) > One question, you suggested to drop "BuildRoot" but it seems after I remove > this macro from spec, this variable '$RPM_BUILD_ROOT' will become undefined > thus causing errors while packaging. Where are you testing? They are no longer need to be defined for Fedora releases or EPEL 6: they are still needed for EPEL5 afaik: https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean But if you really intend to build for EPEL5 I guess you could still keep them. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review