Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=665877 Parag AN(àààà) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #4 from Parag AN(àààà) <panemade@xxxxxxxxx> 2011-06-09 00:59:22 EDT --- Review: 1) Upstream source verified as (sha1sum) ddd683b90f2755163605064deb8fab5f15d22414 1.1.0.tar.gz ddd683b90f2755163605064deb8fab5f15d22414 ../SOURCES/freeDiameter-1.1.0.tar.gz 2) rpmlint output on rpms gave freeDiameter-devel.x86_64: W: no-documentation freeDiameter.x86_64: W: shared-lib-calls-exit /usr/lib64/libfdcore.so.1.1.0 exit@xxxxxxxxxxx freeDiameter.x86_64: W: no-manual-page-for-binary freeDiameterd freeDiameter.x86_64: W: no-manual-page-for-binary freeDiameterd-1.1.0 3 packages and 0 specfiles checked; 0 errors, 4 warnings. 3) Package follows packaging guidelines. Suggestions: 1) The only working download link I found is http://www.freediameter.net/hg/freeDiameter/archive/1.1.0.tar.gz so change the Source0 tag to Source0: http://www.freediameter.net/hg/%{name}/archive/%{version}.tar.gz and add a comment before this Source tag that upstream tarball is renamed to follow %{name}-%{version}.tar.gz conventions. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review