[Bug 711762] Review Request: osc - openSUSE Build Service Commander

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=711762

HaÃkel GuÃmar <karlthered@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?

--- Comment #3 from HaÃkel GuÃmar <karlthered@xxxxxxxxx> 2011-06-08 11:30:43 EDT ---
* i generated a tarball following your instructions in spec, the checksum still
differs but i didn't find any difference using diff
$ sha1sum generated/osc-132.1.tar.gz
2a1069b422292141740a4d0ba839a3bd9e6ec6c8
$ sha1sum osc-0.132.1.tar.gz
ae399f2aeb9108ab5b998731f3473362f2153cd7
$ diff -Naur generated/osc-0.132.1 osc-0.132.1/
<no output>

* rpmlint
$ rpmlint -iv osc-0.132.1-1.fc15.src.rpm 
osc.src: I: checking
osc.src: W: spelling-error Summary(en_US) openSUSE -> opens Use, open SUSE,
open-SUSE
The value of this tag appears to be misspelled. Please double-check.

osc.src: W: spelling-error %description -l en_US Commandline -> Command line,
Command-line, Commanding
The value of this tag appears to be misspelled. Please double-check.

osc.src: W: spelling-error %description -l en_US openSUSE -> opens Use, open
SUSE, open-SUSE
The value of this tag appears to be misspelled. Please double-check.

osc.src: I: checking-url http://www.gitorious.org/opensuse/osc (timeout 10
seconds)
osc.src:65: W: libdir-macro-in-noarch-package (main package)
%{_libdir}/osc/complete
The %{_libdir} or %{_lib} macro was found in a noarch package in a section
that gets included in binary packages.  This is most likely an error because
these macros are expanded on the build host and their values vary between
architectures, probably resulting in a package that does not work properly on
all architectures at runtime. Investigate whether the package is really
architecture independent or if some other dir/macro should be instead.

osc.src: W: invalid-url Source0: osc-0.132.1.tar.gz
The value should be a valid, public HTTP, HTTPS, or FTP URL.

1 packages and 0 specfiles checked; 0 errors, 5 warnings.

$ rpmlint -iv /home/haikel/rpmbuild/RPMS/noarch/osc-0.132.1-1.fc15.noarch.rpm
osc.noarch: I: checking
osc.noarch: W: spelling-error Summary(en_US) openSUSE -> opens Use, open SUSE,
open-SUSE
The value of this tag appears to be misspelled. Please double-check.

osc.noarch: W: spelling-error %description -l en_US Commandline -> Command
line, Command-line, Commanding
The value of this tag appears to be misspelled. Please double-check.

osc.noarch: W: spelling-error %description -l en_US openSUSE -> opens Use, open
SUSE, open-SUSE
The value of this tag appears to be misspelled. Please double-check.

osc.noarch: I: checking-url http://www.gitorious.org/opensuse/osc (timeout 10
seconds)
osc.noarch: W: no-manual-page-for-binary osc-wrapper.py
Each executable in standard binary directories should have a man page.

osc.noarch: W: no-manual-page-for-binary osc_hotshot.py
Each executable in standard binary directories should have a man page.

1 packages and 0 specfiles checked; 0 errors, 5 warnings.

==> you probably misunderstood me about the /usr/lib64/osc/complete, since it's
a non-arch dependent shell script, you should install it in
/usr/lib/osc/complete (to be multilib compliant). Besides it won't break
anything since shell completion configuration file will search autocompletion
helpers in both /usr/lib{,64}/osc/complete

* still builds in mock

as soon as you fix the completion helper location, i'll approve this package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]