Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711764 Yanchuan Nian <yanchuan@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |yanchuan@xxxxxxxxxxxxx --- Comment #1 from Yanchuan Nian <yanchuan@xxxxxxxxxxxxx> 2011-06-08 10:29:14 EDT --- Few comments 1. you must use a full URL to identify where the pristine source code is. see here:https://fedoraproject.org/wiki/Packaging/SourceURL 2.get_source.sh is not necessary here, for it is contained in osc-source_validator-0.1.tar.bz2. You'd better remove Source1 from the spec file. 3.Fedora (as of F-10) does not require the presence of the BuildRoot tag in the spec. see here:https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag 4. The name of the rpm is just what the Source unpacks to, so -n %{name}-%{version} should be removed from %prep. see here:https://fedoraproject.org/wiki/How_to_create_an_RPM_package#.25prep_section:_.25setup_command 5./usr/lib is for architecture-dependent data, while /usr/share is for architecture-independent data. That way, systems with different CPUs can share /usr/share. %install mkdir -p %{buildroot}%{_prefix}/lib/osc/source_validators cp -a [0-9]* helpers %{buildroot}%{_prefix}/lib/osc/source_validators %files %defattr(-,root,root,-) %doc COPYING %{_prefix}/lib/osc should be changed to %install mkdir -p %{buildroot}%{_datarootdir}/osc/source_validators cp -a [0-9]* helpers %{buildroot}%{_datarootdir}/osc/source_validators %files %defattr(-,root,root,-) %doc COPYING %{_datarootdir}/osc see here:https://fedoraproject.org/wiki/How_to_create_an_RPM_package#.25files_and_Filesystem_Hierarchy_Standard_.28FHS.29 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review