Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711547 --- Comment #5 from Peter Lemenkov <lemenkov@xxxxxxxxx> 2011-06-08 03:39:39 EDT --- (In reply to comment #4) > Why is it not necessary? The makefile they create uses those things, if they > are for some reason missing... This isn't required because we have a list of packages installed by default into rpmbuildroot. However explicitly listing them (as you did) is harmless and isn't an issue. > http://koji.fedoraproject.org/koji/taskinfo?taskID=3117116 * Youd package doesn't use CFLAGS - this is a blocker. * Missing COPYING in %doc - this ia a strong requirement. * Also adding Doc as %doc sounds like a generally good idea (as well as "readme" and "updates.htm" files). * What's the purpose of the Data directory? Is it required for normal application's operation or not? I think these are jus an examples so they should be packaged as %doc but I'm not sure. * Correct licensing tag should be GPLv3+ not a "GPLv3 (or later)". -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review